[PATCH] D96663: [InstCombine] Fold nonnull (select c,null,p) to nonnull p

[Juneyoung Lee via Phabricator via llvm-commits]

aqjune added a comment.

In D96663#2562250 <https://reviews.llvm.org/D96663#2562250>, @xbolva00 wrote:

> SimplifyCFG adds llvm.assume for “cond”, we should do it here as well.

It seems SimplifyCFG is introducing `llvm.assume` to preserve information after removing a conditional branch.
In this case, the nonnull attribute is still there, so it might be okay to do the transformation without introducing assume IMO. What do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96663/new/

https://reviews.llvm.org/D96663