[PATCH] D96904: [IR] restrict vector reduction intrinsic types

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 18 06:41:07 PST 2021


RKSimon added a comment.

What about return values? Are they checked to match the reduction vector element?



================
Comment at: llvm/lib/IR/Verifier.cpp:5047
+    Type *ArgTy = Call.getArgOperand(1)->getType();
+    Assert(ArgTy->isFPOrFPVectorTy() && ArgTy->isVectorTy(),
+           "Intrinsic has incorrect argument type!");
----------------
Match arg0 type to arg1 element type? I'm not sure the tablegen ensure that


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96904/new/

https://reviews.llvm.org/D96904



More information about the llvm-commits mailing list