[PATCH] D96904: [IR] restrict vector reduction intrinsic types

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 18 06:00:05 PST 2021


spatel added a comment.

In D96904#2570926 <https://reviews.llvm.org/D96904#2570926>, @fhahn wrote:

> In D96904#2569906 <https://reviews.llvm.org/D96904#2569906>, @nikic wrote:
>
>> Hm okay, this works out fine for the vector reduction intrinsics then. However, the same general problem seems to also affect a number of other intrinsics like `int.vp.*` and `int.matrix.*`, where there is not always an additional constraint that could enforce the vector type.
>
> For the Matrix  intrinsics there are a bunch of extra checks in the IR verifier for constraints that cannot be expressed in tablegen.

Thanks - then I'll add cases for the vector reduction intrinsics to the C++ with the extra logic too. No need to make this hacky.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96904/new/

https://reviews.llvm.org/D96904



More information about the llvm-commits mailing list