[PATCH] D96866: [AArch64] Add some missing Neoverse features

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64.td:1012
+                                      FeaturePostRAScheduler,
+                                      FeatureCrypto,
+                                      FeatureFuseAES,
----------------
dmgreen wrote:
> If this is adding crypto... shouldn't there be a test for that? The one in TargetParserTest?
>From `llvm/unittests/Support/TargetParserTest.cpp`:

       ARMCPUTestParams("neoverse-n2", "armv8.5-a", "crypto-neon-fp-armv8",
                         AArch64::AEK_CRC | AArch64::AEK_CRYPTO |
                             AArch64::AEK_FP | AArch64::AEK_SIMD |
                             AArch64::AEK_FP16 | AArch64::AEK_RAS |
                             AArch64::AEK_LSE | AArch64::AEK_SVE |
                             AArch64::AEK_DOTPROD | AArch64::AEK_RCPC |
                             AArch64::AEK_RDM | AArch64::AEK_MTE |
                             AArch64::AEK_SSBS | AArch64::AEK_SB |
                             AArch64::AEK_SVE2 | AArch64::AEK_SVE2BITPERM |
                             AArch64::AEK_BF16 | AArch64::AEK_I8MM,
                         "8.5-A"),

And from `llvm/include/llvm/Support/AArch64TargetParser.def`:

   AARCH64_CPU_NAME("neoverse-n2", ARMV8_5A, FK_CRYPTO_NEON_FP_ARMV8, false,

So, that all seems alright from the front-end and driver point of view, although looks like I need to add a driver test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96866/new/

https://reviews.llvm.org/D96866