[PATCH] D96791: [SLP] Double UserCost compensation for vector store of aggregate

Anton Afanasyev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 18 02:39:20 PST 2021


anton-afanasyev added a comment.

I can add fp2int sample, but it is not touched by this patch. Actually, its tree built is not vectorized by marking as "tiny" (`R.isTreeTinyAndNotFullyVectorizable()` function), its size is 2 (since fp2int is unary operation, whereas add is binary one). Though it could be fixed by checking that stores are using its result and therefore tree size could be increased. But this looks too hacky, isn't it?

In D96791#2571041 <https://reviews.llvm.org/D96791#2571041>, @RKSimon wrote:

> Please can you cleanup pr40522.ll (remove the metatdata etc.)? Also, PR40522 notes missing fp2int vectorization - please can you add those?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96791/new/

https://reviews.llvm.org/D96791



More information about the llvm-commits mailing list