[PATCH] D96836: [FPEnv][AArch64] Implement lowering of llvm.set.rounding

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 18 01:33:58 PST 2021


david-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:3488
+  // Put new rounding mode into FPSCR[23:22].
+  const unsigned RMMask =
+      ~(AArch64::Rounding::rmMask << AArch64::RoundingBitsPos);
----------------
Should RMMask be uint64_t here since you're creating a MVT::i64 constant?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96836/new/

https://reviews.llvm.org/D96836



More information about the llvm-commits mailing list