[PATCH] D96871: [llvm-dwarfdump][locstats] Unify handling of inlined vars with no loc

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 18 00:57:23 PST 2021


djtodoro added a comment.

In D96871#2568791 <https://reviews.llvm.org/D96871#2568791>, @aprantl wrote:

> This definitely won't hurt, but it's a bit inconsistent. The NULL check is inside collectStatsRecursive(), but the CU check is outside of collectStatsForDie(). It would be nice to be consistent and have all functions handle all DIE types with potentially an early exit at the top rather sometimes having the burden to sanitize the input at the call site.

I agree. Thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96871/new/

https://reviews.llvm.org/D96871



More information about the llvm-commits mailing list