[PATCH] D96710: [DebugInfo] Improve tests for AsmPrinter::emitDwarfUnitLength()

ChenZheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 17 19:30:07 PST 2021


shchenz added a comment.

In D96710#2568111 <https://reviews.llvm.org/D96710#2568111>, @ikudrin wrote:

> In D96710#2567786 <https://reviews.llvm.org/D96710#2567786>, @shchenz wrote:
>
>> @ikudrin Hi, we made another change for `emitDwarfUnitLength` in D96409 <https://reviews.llvm.org/D96409>, I think this patch needs to be further improved for `Hi` parameter. Let me know if you need me to update this patch. Thanks.
>
> I believe it would be more convenient for everyone if you just integrate this change into D96409 <https://reviews.llvm.org/D96409> and take care of all adjustments there. Or you may commandeer this revision, whatever you prefer.

I have integrated this patch to D96409 <https://reviews.llvm.org/D96409>. Thanks for your patch @ikudrin


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96710/new/

https://reviews.llvm.org/D96710



More information about the llvm-commits mailing list