[PATCH] D96922: [Coroutine] Check indirect uses of alloca when checking lifetime info

[Chuanqi Xu via Phabricator via llvm-commits]

ChuanqiXu added inline comments.


================
Comment at: llvm/lib/Transforms/Coroutines/CoroFrame.cpp:1012
+    // every basic block that uses the pointer to see if they cross suspension
+    // points. The uses cover both direct uses as well as indirect usees.
+    // If lifetime information suggests that the pointer never need to live
----------------
usees -> uses 


================
Comment at: llvm/lib/Transforms/Coroutines/CoroFrame.cpp:1025
+      if (!CheckLifetime())
+        return false;
+    }
----------------
Should we add `else return true;`?  Since `Users` already contains the alias of the `alloca`, the code above already checks whether lifetime start info and the indirect uses cross suspend points.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96922/new/

https://reviews.llvm.org/D96922