[PATCH] D95993: Add auto-upgrade support for annotation intrinsics

[Andy Kaylor via Phabricator via llvm-commits]

andrew.w.kaylor added inline comments.


================
Comment at: llvm/lib/IR/AutoUpgrade.cpp:3759
+    // the old call and replace the uses.
+    if (!CI->use_empty()) {
+      Value *NewRetVal = Builder.CreateBitCast(NewCall, CI->getType());
----------------
Tyker wrote:
> Tyker wrote:
> > since the return type of annotation didn't change i am not sure this is necessary.
> i am not sure the bitcast is necessary.
Yes, you're right. I was thinking about the fact that the function type changed, but that doesn't affect the return value type, so the bitcast is not needed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95993/new/

https://reviews.llvm.org/D95993