[PATCH] D96629: [llvm][TextAPI] add equality operator for InterfaceFile

Steven Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 17 13:46:06 PST 2021


steven_wu accepted this revision.
steven_wu added a comment.
This revision is now accepted and ready to land.

Looks good. with a small comment inline.



================
Comment at: llvm/unittests/TextAPI/TextStubV3Tests.cpp:908
+                         void (*Transform)(InterfaceFile *)) {
+  Transform(&FileA);
+  EXPECT_FALSE(FileA == FileB);
----------------
NIT: You can redo this function as a lambda in the test function so it only takes the transform function as parameter. FileA and FileB is freshly created from TBD file in the beginning and the TBDv3File can just be a lambda capture.




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96629/new/

https://reviews.llvm.org/D96629



More information about the llvm-commits mailing list