[PATCH] D91426: [PowerPC] Fix issue where binary uses a .got but is missing a .TOC.

Stefan Pintilie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 17 13:42:50 PST 2021


stefanp added a comment.

In D91426#2568567 <https://reviews.llvm.org/D91426#2568567>, @sfertile wrote:

> Could there be a simpler approach where we always emit a .got section on PPC64:  In `addReservedSymbols` if we fail to resolve `.TOC.` then we create it?

We could do that and it would certainly solve the problem. The issue I have with that is that we will now have a `.got` for everything we link including things that we used to link in the past that did not require it. It seems odd to say that since the design of the linker won't allow us to do this easily we will generate this section whether we need it or not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91426/new/

https://reviews.llvm.org/D91426



More information about the llvm-commits mailing list