[PATCH] D96629: [llvm][TextAPI] add equality operator for InterfaceFile

[Cyndy Ishida via Phabricator via llvm-commits]

cishida added inline comments.


================
Comment at: llvm/unittests/TextAPI/TextStubV4Tests.cpp:1120
+
+void resetFiles(InterfaceFile &FileA, InterfaceFile &FileB,
+                const char *TBDv4File) {
----------------
These functions are the same except variable name between these files, we have a `TextStubHelpers.h` file in the unit tests, can we just move these there? 


================
Comment at: llvm/unittests/TextAPI/TextStubV4Tests.cpp:1133
+
+TargetList getTargets() {
+  return {Target(AK_i386, PlatformKind::macOS),
----------------
If this is refactoring the multiple times we use this, it should just be a variable we can call not a function. 


================
Comment at: llvm/unittests/TextAPI/TextStubV4Tests.cpp:1138
+
+void transformAttrExists(InterfaceFile &FileA, InterfaceFile &FileB,
+                         const char *TBDv4File,
----------------
how about `updateAttributeThenReset`? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96629/new/

https://reviews.llvm.org/D96629