[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:1131
   NegFlag<SetFalse, [], "Disable code coverage analysis">, BothFlags<[CoreOption]>>;
+def fcoverage_compilation_dir : Separate<["-"], "fcoverage-compilation-dir">,
+    Group<f_Group>, Flags<[CC1Option, CC1AsOption, CoreOption]>,
----------------
phosek wrote:
> MaskRay wrote:
> > Using fcoverage_compilation_dir_EQ for both driver option and CC1 option is preferred.
> > 
> > Can you drop fcoverage_compilation_dir ?
> I've been following `-fdebug-compilation-dir` which supports both variants. Should we drop `-fdebug-compilation-dir` as well? I'd like to keep these consistent.
We cannot drop the driver option `-fdebug-compilation-dir X` now for compatibility reasons: D96886.

Newer options should stick with the convention, not adding more Separate< forms.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95753/new/

https://reviews.llvm.org/D95753