[PATCH] D95539: [LV] Add analysis remark for mixed precision conversions
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 17 12:22:22 PST 2021
fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.
LGTM thanks! If you can, it might be good to add another test case where we emit multiple remarks.
================
Comment at: llvm/test/Transforms/LoopVectorize/mixed-precision-remarks.ll:33
+
+for.cond.cleanup:
+ ret void
----------------
tiniest nit: now that we only branch to this block from `for.body`, it seems more naturally to have it at the end of the function :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95539/new/
https://reviews.llvm.org/D95539
More information about the llvm-commits
mailing list