[PATCH] D96770: [lld][WebAssembly] Fix resolveIndirectFunctionTable for relocatable output

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 17 11:09:32 PST 2021


sbc100 accepted this revision.
sbc100 added a comment.
This revision is now accepted and ready to land.

lgtm with a test for the new error(s).



================
Comment at: lld/wasm/Driver.cpp:475
+    if (config->exportTable)
+      error("--relocatable is incompatible with --export-table");
+    // Ignore any --import-table, as it's redundant.
----------------
Can you do the same for `growableTable`?   Probably good to have a test too.   


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96770/new/

https://reviews.llvm.org/D96770



More information about the llvm-commits mailing list