[PATCH] D96416: [TableGen] Improve algorithms for processing template arguments; add type checking

Paul C. Anagnostopoulos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 17 10:47:54 PST 2021


Paul-C-Anagnostopoulos added a comment.

Okay, so the only trick I know to check the difference in anonymous record count is to take a copy of AMDGPUGenGlobalISel.inc generated under main and a copy generated under these changes and global replace all occurrences of 'anonymous_nnnnn' with 'xxx'. That normalizes them with respect to anonymous record names. Then I diff the two files. They are identical.

So I am going to somewhat rashly assume that the reduction in anonymous records is not a problem. I will push this revision on Thursday and stand by to see what happens. Meanwhile I will think about why this might happen.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96416/new/

https://reviews.llvm.org/D96416



More information about the llvm-commits mailing list