[PATCH] D86142: [LLD] Search archives for non-tentative defintions.

Wed Feb 17 10:04:30 PST 2021

MaskRay added a comment.

In D86142#2568879 <https://reviews.llvm.org/D86142#2568879>, @dmajor wrote:

> We're seeing errors about duplicate gcov symbols in Rust code after this change: https://bugs.llvm.org/show_bug.cgi?id=49226
>
> Is it expected that this commit would affect non-Fortran code?

@dmajor Yes, any object file with common symbols (SHN_COMMON or (rare) STT_COMMON) may observed changed behaviors.
clang 11 and gcc 10 default to -fno-common, so you probably will not observe SHN_COMMON.

LLD<12, gold, macOS ld64 and GNU ld before 1999-12 have the `--no-fortran-common` behavior.
LLD>=12, GNU ld since 1999-12 have the `--fortran-common` behavior.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86142/new/

https://reviews.llvm.org/D86142