[PATCH] D95503: [AMDGPU] WQM/WWM: Fix marking of partial definitions

[Piotr Sobczak via Phabricator via llvm-commits]

piotr added a comment.

Looks go to me (with two nits inline).



================
Comment at: llvm/lib/Target/AMDGPU/SIWholeQuadMode.cpp:311
+          // Compute lanes defined and overlap with use
+          LaneBitmask DefLanes =
+              Op.isUndef() ? LaneBitmask::getAll()
----------------
DefLanes is a bit too similar to DefinedLanes. Can you rename one of them please?


================
Comment at: llvm/lib/Target/AMDGPU/SIWholeQuadMode.cpp:317
+          // Record if this instruction defined any of use
+          HasDef = HasDef | Overlap.any();
+
----------------
HasDef |= Overlap.any();


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95503/new/

https://reviews.llvm.org/D95503