[PATCH] D96371: [lit] Add --ignore-fail

[Joel E. Denny via Phabricator via llvm-commits]

jdenny marked an inline comment as done.
jdenny added a comment.

In D96371#2567707 <https://reviews.llvm.org/D96371#2567707>, @jhenderson wrote:

> Okay. I'm happy to proceed.

Thanks for considering it.  Likewise to @thopre.

> I think the lit documentation needs updating to mention this change?

You mean lit.rst?  I'm happy to put it there.  However, first, what is the threshold in general?  Many options are missing there.  Is that intentional or by accident?  (If it's always by accident, we really ought to consider generating that part from `lit --help` so we don't have to maintain two versions of the same thing.  That should be a different patch of course.)



================
Comment at: llvm/utils/lit/tests/ignore-fail.py:7
+
+# END.
+
----------------
jhenderson wrote:
> What's the point of this line?
Without it, lit chokes on `XFAIL:` below.  I actually didn't notice it mattered when I wrote it.  But I'm developing a habit of using `END.` in lit's test suite, where lit directives often appear in FileCheck patterns.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96371/new/

https://reviews.llvm.org/D96371