[PATCH] D96416: [TableGen] Improve algorithms for processing template arguments; add type checking

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 17 09:03:33 PST 2021


foad added a comment.

In D96416#2568659 <https://reviews.llvm.org/D96416#2568659>, @Paul-C-Anagnostopoulos wrote:

> @foad Something interesting is going on with the AMDGPU TableGen files. When I print all the definitions under main, there are 18,195 anonymous records. When I print them under these changes, there are 18,152 anonymous records. This suggests that fewer casts of records from one class to another are done under these changes. I'm not sure how that is possible. I will investigate further.

Interesting. Do the generated files `lib/Target/AMDGPU/*.inc` come out identical?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96416/new/

https://reviews.llvm.org/D96416



More information about the llvm-commits mailing list