[PATCH] D96872: [WebAssembly][lld] --importTable flag only imports table if needed

Andy Wingo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 17 08:53:06 PST 2021


wingo marked an inline comment as done.
wingo added inline comments.


================
Comment at: lld/wasm/Driver.cpp:834
+    return cast_or_null<TableSymbol>(existing);
   } else if ((existing && existing->isLive()) || config->exportTable) {
     // A defined table is required.  Either because the user request an exported
----------------
sbc100 wrote:
> I'm seeing `Driver.cpp:802:21: warning: unused function 'createUndefinedIndirectFunctionTable' [-Wunused-function]
> static TableSymbol *createUndefinedIndirectFunctionTable(StringRef name) {`
> 
Heh yeah, just fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96872/new/

https://reviews.llvm.org/D96872



More information about the llvm-commits mailing list