[PATCH] D95998: [Debug-Info] [NFC] use emitDwarfUnitLength to handle debug line section unit length field
Igor Kudrin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 17 04:20:09 PST 2021
ikudrin added a comment.
In D95998#2567599 <https://reviews.llvm.org/D95998#2567599>, @dblaikie wrote:
> What if the function created and returned Hi rather than taking it as an argument?
Hmm, I can't say I'm a vivid fan of this change. All methods of `MCStremer` instruct it to do something, i.e. it roles as just a performer. With this change, it now requests a caller to do some action. It looks like inverting customer vs. performer roles for this particular case.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95998/new/
https://reviews.llvm.org/D95998
More information about the llvm-commits
mailing list