[PATCH] D96823: [AMDGPU] Mark SMRD atomics

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 16 17:04:17 PST 2021


rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SMInstructions.td:600
+  : SMEM_Real_vi <op, ps>,
+    AtomicNoRet <!subst("_RTN","",NAME), ps.glc> {
 
----------------
arsenm wrote:
> Why parse this out instead of appending _RTN?
It is real, _RTN is in the middle and full name is not available. I could construct proper name from the multiclass instantiating this, but it is more code.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96823/new/

https://reviews.llvm.org/D96823



More information about the llvm-commits mailing list