[PATCH] D96639: [AMDGPU] Add two TSFlags: IsAtomicNoRtn and IsAtomicRtn

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

Looks good. Can you remove the getAtomicRetOp table if it's not used for anything?



================
Comment at: llvm/lib/Target/AMDGPU/SIDefines.h:111
+
+  IsAtomicNoRtn = UINT64_C(1) << 57,
+
----------------
This one lacks a comment.

Can you spell it "IsAtomicNoRet"? I don't think we use the "rtn"/"nortn" spelling anywhere else.


================
Comment at: llvm/lib/Target/AMDGPU/SIDefines.h:114
+  // Atomic with return.
+  IsAtomicRtn = UINT64_C(1) << 58
 };
----------------
"IsAtomicRet"?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96639/new/

https://reviews.llvm.org/D96639