[PATCH] D96870: [flang][f18] Make -fdebug-dump-{} imply -fsyntax-only - revert

Andrzej Warzynski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 17 07:31:10 PST 2021


awarzynski created this revision.
awarzynski requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This patch reverts the changes in `f18` introduced in
https://reviews.llvm.org/D96528.

The new driver will run only the action corresponding to the final
action option. For this reason, we need to make sure that
`-fsyntax-only` _is not_ the final option on the command line and all
tests are updated to use:

  -fsyntax-only -fdebug-dump-symbols

rather than

  -fdebug-dump-symbols -fsyntax-only

This way we can guarantee that tests using `-fdebug-dump-symbols` and
`-fdebug-dump-parse-tree` will continue working for both drivers,
despite the underlying implementation being a bit different.

The affected dump options:

- -fdebug-dump-symbols
- -fdebug-dump-parse-tree

are introduced in `flang-new` in https://reviews.llvm.org/D96716.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D96870

Files:
  flang/test/Evaluate/test_folding.sh
  flang/test/Semantics/data05.f90
  flang/test/Semantics/data08.f90
  flang/test/Semantics/offsets01.f90
  flang/test/Semantics/offsets02.f90
  flang/test/Semantics/offsets03.f90
  flang/test/Semantics/oldparam01.f90
  flang/test/Semantics/resolve100.f90
  flang/test/Semantics/rewrite01.f90
  flang/test/Semantics/typeinfo01.f90
  flang/tools/f18/f18.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D96870.324309.patch
Type: text/x-patch
Size: 4947 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210217/321fea3b/attachment.bin>


More information about the llvm-commits mailing list