[PATCH] D96868: build: Add LLVM_WINSYSROOT to make setting /winsysroot easy on Win

[Hans Wennborg via Phabricator via llvm-commits]

hans accepted this revision.
hans added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/utils/sysroot.py:3
+
+"""Helps manage sysroots."""
+
----------------
thakis wrote:
> hans wrote:
> > Can you expand on what "manage" could mean in the future? The current filename is pretty general, so if the main purpose is to set up sysroots (fake or not) maybe a better name would be make_sysroot.py?
> I was thinking (at least on linux): creating, uploading a created sysroot, downloading a pre-uploaded sysroot. Hence the general name :)
Ah, yes that sounds pretty general. Maybe put some of that in the comment here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96868/new/

https://reviews.llvm.org/D96868