[PATCH] D96868: build: Add LLVM_WINSYSROOT to make setting /winsysroot easy on Win

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 17 07:15:26 PST 2021


hans added inline comments.


================
Comment at: llvm/utils/sysroot.py:3
+
+"""Helps manage sysroots."""
+
----------------
Can you expand on what "manage" could mean in the future? The current filename is pretty general, so if the main purpose is to set up sysroots (fake or not) maybe a better name would be make_sysroot.py?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96868/new/

https://reviews.llvm.org/D96868



More information about the llvm-commits mailing list