[PATCH] D48803: Place the BlockAddress type in the address space of the containing function

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 17 07:09:23 PST 2021


arichardson added inline comments.


================
Comment at: llvm/lib/AsmParser/LLParser.cpp:3459
+          if (!ExpectedTy->isPointerTy() ||
+              !ExpectedTy->getPointerElementType()->isIntegerTy(8))
+            return error(
----------------
arsenm wrote:
> This should not depend on pointee element types
I've kept this check for now (with a TODO) and only updated the error message.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D48803/new/

https://reviews.llvm.org/D48803



More information about the llvm-commits mailing list