[PATCH] D48803: Place the BlockAddress type in the address space of the containing function
Alexander Richardson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 17 06:30:33 PST 2021
arichardson added inline comments.
================
Comment at: llvm/docs/LangRef.rst:3820-3821
+(Harvard architectures) will be in the program memory address space specified
+in the target's data layout unless the target can place functions in
+multiple different address spaces.
+
----------------
arsenm wrote:
> I think this is overexplaining it. The IR is the same regardless of what the target wants to do. It should match the code address space of the function
I believe the following should be sufficient, right?
> It always has an ``i8 addrspace(P)*`` type, where ``P`` is the address space
> of the function containing ``%block``.
@dylanmckay are you happy with dropping the the remaining text?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D48803/new/
https://reviews.llvm.org/D48803
More information about the llvm-commits
mailing list