[PATCH] D96862: Allow passing /manifestdependency via #pragma comment(linker, ...)

[Colin Finck via Phabricator via llvm-commits]

ColinFinck created this revision.
ColinFinck added a reviewer: lld.
ColinFinck added a project: lld.
ColinFinck requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Linker commands added via `#pragma comment(linker, ...)` are passed to the linker via a `.drectve` section.
Current lld-link however rejects `/manifestdependency` arguments passed this way.
They are very common for enabling Visual Styles in Win32 GUI applications.

I have found https://bugs.llvm.org/show_bug.cgi?id=38797 opened over 2 years ago along with a simple one-liner patch.
I've updated this patch for latest lld as the bug still persists.

I have no LLVM commit access, so someone else has to commit this.
My author information: `Colin Finck <colin at reactos.org>`

Other involved authors from the bug report:

- `Roland Reichwein <mail at reichwein.it>`
- `Jaromir Kuba <kuba at gdpr-pardubice.cz>`


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D96862

Files:
  lld/COFF/Driver.cpp


Index: lld/COFF/Driver.cpp
===================================================================
--- lld/COFF/Driver.cpp
+++ lld/COFF/Driver.cpp
@@ -424,6 +424,7 @@
     // `#pragma comment(linker, "/flag")`-generated sections.
     case OPT_editandcontinue:
     case OPT_guardsym:
+    case OPT_manifestdependency:
     case OPT_throwingnew:
       break;
     default:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D96862.324277.patch
Type: text/x-patch
Size: 370 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210217/6ea7a20d/attachment.bin>