[PATCH] D93963: [GlobalISel][AMDGPU] Lower G_UMULO/G_SMULO

[Pushpinder Singh via Phabricator via llvm-commits]

pdhaliwal added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:1891
+  unsigned SrcBitWidth = SrcTy.getScalarSizeInBits();
+  MachineInstrBuilder LeftOperand, RightOperand;
+
----------------
foad wrote:
> foad wrote:
> > Maybe assert that WideTy is at least twice as wide as SrcTy, otherwise the trick we use for calculating overflow below does not work.
> Did you test with assertions enabled? I think this needs to be `>=`.
Thanks for pointing out. I was not testing with assertions enabled so I missed it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93963/new/

https://reviews.llvm.org/D93963