[PATCH] D88629: [lld-macho] Add ARM64 target arch

[Mikael Holmén via Phabricator via llvm-commits]

uabelho added inline comments.


================
Comment at: lld/MachO/Arch/ARM64.cpp:74
+         "invalid relocation type");
+  if (type < 0 || type >= relocAttrsArray.size())
+    return TargetInfo::invalidRelocAttrs;
----------------
uabelho wrote:
> gcc warns about "type < 0" always being false since type is unsigned.
> Can it be removed?
> 
> Similarly with the assert above, I suppose type >= 0 is always true and it can be removed.
I removed the always true/false conditions in
https://reviews.llvm.org/rGcaff023b7799
to silence compiler warnings.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88629/new/

https://reviews.llvm.org/D88629