[PATCH] D96710: [DebugInfo] Improve tests for AsmPrinter::emitDwarfUnitLength()

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 16 22:52:07 PST 2021


ikudrin added a comment.

In D96710#2566459 <https://reviews.llvm.org/D96710#2566459>, @dblaikie wrote:

> Sure, sounds OK. Though a lot of this is probably OK/already tested by assembly level tests, I'd expect.

Thanks! Right, there are other tests that go through this path, but their purposes are different, so they might be changed. Contrary, these are unit tests, and they are focused on the expected behavior of particular methods.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96710/new/

https://reviews.llvm.org/D96710



More information about the llvm-commits mailing list