[PATCH] D96796: [mlgo] Fetch models from path / URL

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 16 22:34:22 PST 2021


mtrofin added inline comments.


================
Comment at: llvm/cmake/modules/TensorFlowCompile.cmake:16
+    string(FIND ${model} "/" fname_start REVERSE)
+    MATH(EXPR fname_start "${fname_start}+1")
+    string(SUBSTRING ${model} ${fname_start}+1 -1 fname)
----------------
phosek wrote:
> Super minor nit: all the other functions are spelled as lower case.
removed that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96796/new/

https://reviews.llvm.org/D96796



More information about the llvm-commits mailing list