[PATCH] D96796: [mlgo] Fetch models from path / URL

[Petr Hosek via Phabricator via llvm-commits]

phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.

I'm not sure about the use case for the remote download feature (you can always just `curl <URL> | tar xvz`). If it's not needed, then I'd skip it for now, we can always introduce it later.



================
Comment at: llvm/cmake/modules/TensorFlowCompile.cmake:16
+    string(FIND ${model} "/" fname_start REVERSE)
+    MATH(EXPR fname_start "${fname_start}+1")
+    string(SUBSTRING ${model} ${fname_start}+1 -1 fname)
----------------
Super minor nit: all the other functions are spelled as lower case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96796/new/

https://reviews.llvm.org/D96796