[PATCH] D95969: [WPD] Add an optional checking mode for debugging devirtualization

Tue Feb 16 18:23:38 PST 2021

tejohnson added a comment.

In D95969#2567073 <https://reviews.llvm.org/D95969#2567073>, @pcc wrote:

> In D95969#2567029 <https://reviews.llvm.org/D95969#2567029>, @tejohnson wrote:
>
>> In D95969#2566916 <https://reviews.llvm.org/D95969#2566916>, @pcc wrote:
>>
>>> Can you use `SplitBlockAndInsertIfThen` instead of `versionCallSite` here? I personally don't find the name `versionCallSite` very intuitive here.
>>
>> There's a bunch of handling in versionCallSite for things like must tail calls and invoke instructions that I think I would end up needing to replicate, along with the general case. Calling versionCallSite makes things easy since it handles all of this. Would it help to expand the comment above the call?
>
> You're just adding some code before the call, no? That means that you don't need to touch the call itself.

Yeah actually this is a good reason to go with David's earlier suggestion of changing the if condition. Let me go ahead and do that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95969/new/

https://reviews.llvm.org/D95969