[PATCH] D96827: [DWARF][WIP] Check for AddrOffsetSectionBase to work with DWO Units.

Alexander Yermolovich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 16 18:23:01 PST 2021


ayermolo created this revision.
Herald added subscribers: hoy, wenlei, hiraditya.
ayermolo requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Context: https://lists.llvm.org/pipermail/llvm-dev/2021-February/148521.html

Work in progress diff, to start a conversation how to fix address/location apis for debug fission.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D96827

Files:
  llvm/lib/DebugInfo/DWARF/DWARFUnit.cpp


Index: llvm/lib/DebugInfo/DWARF/DWARFUnit.cpp
===================================================================
--- llvm/lib/DebugInfo/DWARF/DWARFUnit.cpp
+++ llvm/lib/DebugInfo/DWARF/DWARFUnit.cpp
@@ -192,7 +192,7 @@
 
 Optional<object::SectionedAddress>
 DWARFUnit::getAddrOffsetSectionItem(uint32_t Index) const {
-  if (IsDWO) {
+  if (IsDWO && !AddrOffsetSectionBase) {
     auto R = Context.info_section_units();
     // Surprising if a DWO file has more than one skeleton unit in it - this
     // probably shouldn't be valid, but if a use case is found, here's where to


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D96827.324150.patch
Type: text/x-patch
Size: 580 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210217/db662e1e/attachment.bin>


More information about the llvm-commits mailing list