[PATCH] D96757: [InstrProfiling] Use ELF section groups for counters, data and values

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Does this mean that for non-COMDAT `__llvm_prf_*` sections, we now need one section header (`.group`) for -ffunction-sections use cases? `sizeof(Elf64_Shdr)=64` the size overhead can be quite significant.

> This is an alternative to D76802 <https://reviews.llvm.org/D76802> which uses zero-flag ELF section groups instead of SHF_LINK_ORDER. While testing D76802 <https://reviews.llvm.org/D76802>, we keep running into issues in real-world code, but this variant seems to be working.

Would be good to know the root cause. `SHF_LINK_ORDER` is the perfect alternative to COFF `comdat nodeduplicates` here as both solutions don't have space overhead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96757/new/

https://reviews.llvm.org/D96757