[PATCH] D95969: [WPD] Add an optional checking mode for debugging devirtualization

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

In D95969#2566916 <https://reviews.llvm.org/D95969#2566916>, @pcc wrote:

> Can you use `SplitBlockAndInsertIfThen` instead of `versionCallSite` here? I personally don't find the name `versionCallSite` very intuitive here.

There's a bunch of handling in versionCallSite for things like must tail calls and invoke instructions that I think I would end up needing to replicate, along with the general case. Calling versionCallSite makes things easy since it handles all of this. Would it help to expand the comment above the call?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95969/new/

https://reviews.llvm.org/D95969