[PATCH] D96528: [flang][f18] Make -fdebug-dump-{symbols|parse-tree} imply -fsyntax-only

Andrzej Warzynski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 16 14:24:41 PST 2021


awarzynski added a comment.

In D96528#2566476 <https://reviews.llvm.org/D96528#2566476>, @klausler wrote:

> In D96528#2566468 <https://reviews.llvm.org/D96528#2566468>, @awarzynski wrote:
>
>> Apologies for disrupting your workflow.  Just to double check - you want to use `-fdebug-dump-symbols` and then have `f18` call the external compiler?
>>
>> I will upload a patch that restores the original behavior in `f18`.
>
> I don't think that you can do that without also reverting changes to tests, and we probably don't want to do that.

That's true, but we can update the tests to use: `-fsyntax-only -fdebug-dump-parse-tree`:

- this restores the original behavior for `f18`
- the new driver will _ignore_ `-fsyntax-only` and run `-fdebug-dump-parse-tree` only (so this would be fine for `flang-new` as well)

Originally some tests had `-fdebug-dump-parse-tree -fsyntax-only` and that order is problematic for the new driver (it only respects the last _action_).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96528/new/

https://reviews.llvm.org/D96528



More information about the llvm-commits mailing list