[PATCH] D96653: [FileCheck] Add neighboring annotations for -dump-input-filter=error

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added inline comments.


================
Comment at: llvm/test/FileCheck/dump-input/filter-error-neighbor/multiline.txt:1-11
+; -dump-input-filter=error reveals only the first or last line of an annotation
+; neighboring an error, depending on whether it precedes or follows the error.
+; This test checks that we don't mix up first and last.  Otherwise, a preceding
+; or following annotation can accidentally be omitted altogether.  Of course,
+; we must have multiline annotations so that first != last.
+;
+; This test also checks that CHECK-LABEL is handled in the same way.  That is,
----------------
thopre wrote:
> Could you do like the other tests and explain what input lines are revealed by this code?
Done.  In most tests, I also clarified which lines are specifically revealed by `-dump-input-filter=error` vs. the lines added by `-dump-input-context=2`.


================
Comment at: llvm/utils/FileCheck/FileCheck.cpp:158-160
                           "Input lines with starting points of error "
+                          "annotations or with annotations that neighbor error "
                           "annotations")));
----------------
jdenny wrote:
> thopre wrote:
> > Isn't there one too many "annotations" in that sentence?
> Semantically and grammatically, I think it's correct.  Is your concern that so many occurrences of "annotations" makes it confusing?
I've made an attempt at clarifying the sentence.  Please let me know if it helped.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96653/new/

https://reviews.llvm.org/D96653