[PATCH] D96678: [llvm-dwp] Join dwo paths correctly when DWOPath is absolute

[Simonas Kazlauskas via Phabricator via llvm-commits]

nagisa added a comment.

Just so that it doesn't get lost between hidden comments: I've no commit bit, please commit this for me if this is good to go.



================
Comment at: llvm/test/tools/llvm-dwp/X86/absolute_paths.test:8-15
+; CHECK-LABEL: .debug_abbrev.dwo contents:
+; CHECK: DW_AT_name
+; CHECK: DW_AT_GNU_dwo_name
+; CHECK: DW_AT_name
+; CHECK-LABEL: .debug_str.dwo contents:
+; CHECK: "banana"
+; CHECK: "/tmp/test.c"
----------------
dblaikie wrote:
> Maybe only dump/test the debug_info section ( `llvm-dwarfdump %t/test.dwp` should do that, only dumping the debug_info section by default) and check DW_AT_subprogram has a DW_AT_name of "banana" - would check this specific dwo file was included in the dwp (& indirectly exercises a bunch of other functionality, like index usage, strings, abbreviations, etc).
Looks like doing so doesn't work out in this particular test. On windows the dwarfdump output gets escaped in a way and `-DPATH` that we pass in is not escaped (the same way). cf. [this](https://reviews.llvm.org/harbormaster/unit/view/394878/). I'm not seeing a good way to match the string so I'm going to keep the test as it was originally written.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96678/new/

https://reviews.llvm.org/D96678