[PATCH] D96662: [lit] Add --skip (inverse of --filter) and `--xfail`

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added inline comments.


================
Comment at: llvm/docs/CommandGuide/lit.rst:215
+  Skip those tests whose name matches the regular expression specified in
+  ``REGEXP``. The environment variable ``LIT_SKIP`` can be also used in place
+  of this option, which is especially useful in environments where the call
----------------
davezarzycki wrote:
> jdenny wrote:
> > Why do we need more environment variables?  Isn't `LIT_OPTS` sufficient?  (`LIT_FILTER`, etc. predate `LIT_OPTS`.)
> I'm generally biased against designs that require thinking about shell escaping (or at least more than necessary).
I've been using `--filter` within `LIT_OPTS` for a while because I use `LIT_OPTS` for other purposes anyway.  I don't find the escaping to be challenging.  However, maybe quoting is harder in some shells, or maybe I've not imagined some use cases.  OK, fair enough.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96662/new/

https://reviews.llvm.org/D96662