[PATCH] D96631: [flang] Detect circularly defined procedures

Tim Keith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 16 12:33:03 PST 2021


tskeith accepted this revision.
tskeith added a comment.

LGTM



================
Comment at: flang/test/Semantics/resolve100.f90:4
+! Tests for circularly defined procedures
+!ERROR: Procedure 'sub' is recursively defined.  Procedures in the cycle: 'sub, p2'
+subroutine sub(p2)
----------------
PeteSteinfeld wrote:
> tskeith wrote:
> > I think the procedure names should be quoted individually, i.e. `'sub', 'p2'`.
> Will do.
There are extra quotes around the whole list.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96631/new/

https://reviews.llvm.org/D96631



More information about the llvm-commits mailing list