[PATCH] D96629: [llvm][TextAPI] add equality operator for InterfaceFile

Cyndy Ishida via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 16 11:51:27 PST 2021


cishida added inline comments.


================
Comment at: llvm/lib/TextAPI/MachO/InterfaceFile.cpp:111
+void InterfaceFile::addDocument(std::shared_ptr<InterfaceFile> &&Document) {
+  auto Pos = std::lower_bound(Documents.begin(), Documents.end(), Document,
+                              [](const std::shared_ptr<InterfaceFile> &LHS,
----------------
can we use `llvm::lower_bound` instead?  it supports passing a range instead of boilerplate iterators. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96629/new/

https://reviews.llvm.org/D96629



More information about the llvm-commits mailing list