[PATCH] D96678: [llvm-dwp] Join dwo paths correctly when DWOPath is absolute

[Simonas Kazlauskas via Phabricator via llvm-commits]

nagisa added inline comments.


================
Comment at: llvm/test/tools/llvm-dwp/X86/absolute_paths.test:4
+; RUN: llc %s --split-dwarf-file=%t/test.dwo --split-dwarf-output=%t/test.dwo --filetype=obj -o %t/test.o
+; RUN: llvm-dwp -e %t/test.o -o %t/test.dwp
+
----------------
dblaikie wrote:
> Should this have some CHECKs for certain behavior (dumping the resulting dwp and checking things, for instance)
> 
> "does something other than crashing/failing" is a pretty low bar for a test, doesn't especially check that this behaves in a way we would want it to.
I added some CHECK lines that should at least verify that the `llvm-dwp` picks up the right `dwo` file (by the virtue of both the files having (mostly?) the same contents).

I had a pretty hard time coming up with something more meaningful than that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96678/new/

https://reviews.llvm.org/D96678