[PATCH] D96636: [lld][ELF] Support for zero flag section groups

[Petr Hosek via Phabricator via llvm-commits]

phosek added inline comments.


================
Comment at: lld/ELF/InputFiles.cpp:621
 
       bool isNew =
+          (flag & GRP_COMDAT) == 0 || ignoreComdats ||
----------------
jhenderson wrote:
> I wonder whether `isNew` is a bit misnamed nowadays. Perhaps it should be renamed to `keepGroup` or something like that. Waht do you think?
That makes sense, I've renamed this to `keepGroup`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96636/new/

https://reviews.llvm.org/D96636