[PATCH] D96455: [SampleFDO][NFC] Refactor SampleProfile.cpp

[Rong Xu via llvm-commits]

Thanks for the update!
I agree that the probe based part can be moved to the base later. Once all
the lineno based code is in place, moving code should be straightforward.

-Rong

On Tue, Feb 16, 2021 at 10:51 AM Hongtao Yu via Phabricator <
reviews at reviews.llvm.org> wrote:

> hoy accepted this revision.
> hoy added a comment.
>
> Sorry for the late response. We've been thinking about the integration
> with CSSPGO. May need to move more stuff (like `getProbeWeight`) into the
> base class for MIR support.
>
> Current changes look good to me. Thanks.
>
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D96455/new/
>
> https://reviews.llvm.org/D96455
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210216/9943d58b/attachment.html>