[PATCH] D96780: [NPM][LTO] Update buildLTODefaultPipeline to be more in-line with the old pass manager

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 16 10:16:30 PST 2021


dmgreen added inline comments.


================
Comment at: llvm/lib/Passes/PassBuilder.cpp:1740
   // Nuke dead stores.
   MainFPM.addPass(DSEPass());
+  // FIXME: once we provide support for enabling MLSM, add it here.
----------------
dmgreen wrote:
> fhahn wrote:
> > It looks like there are a few other passes missing here, like `LoopDeletion` and `MergedLoadStoreMotionPass`, and conditionally `LoopInterchange`/`ConstraintElimination`. Should they be added as well? 
> I was trying to keep this simple, to fix the regressions sooner rather than later. I'll see what I can do to add a few others.
LoopInterchange I've not added because it's not anywhere in the NPM yet. It can be added when it's added to the main optimization passes. The others should be here now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96780/new/

https://reviews.llvm.org/D96780



More information about the llvm-commits mailing list